-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse purls cautiously in getDeniedChanges #753
Conversation
1e3e4d6
to
abc088e
Compare
abc088e
to
2034bab
Compare
7a330f2
to
45a8276
Compare
45a8276
to
1dd418b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few clarifying comments, but overall LGTM 👍 Thanks for the help on this one and sorry for the release headaches. It should be have been a smell when we had to hack packageurl-js to fit our use case.
The build is breaking, but it looks like it's because it's pulling from the main
branch and still using the packageurl-js so we should be good to merge here?
@@ -59,7 +59,7 @@ inputs: | |||
description: A comma-separated list of package URLs to deny (e.g. "pkg:npm/express, pkg:pypi/pycrypto"). If version specified, only deny matching packages and version; else, deny all regardless of version. | |||
required: false | |||
deny-groups: | |||
description: A comma-separated list of package URLs for group(s)/namespace(s) to deny (e.g. "pkg:npm/express, pkg:pypi/pycrypto") | |||
description: A comma-separated list of package URLs for group(s)/namespace(s) to deny (e.g. "pkg:npm/express/, pkg:pypi/pycrypto/"). Please note that the group name must be followed by a `/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
That's right, yeah. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://github.com/actions/checkout) | action | patch | `v4.1.1` -> `v4.1.7` | | [actions/dependency-review-action](https://github.com/actions/dependency-review-action) | action | minor | `v4.2.5` -> `v4.3.3` | | [actions/download-artifact](https://github.com/actions/download-artifact) | action | patch | `v4.1.4` -> `v4.1.7` | | [actions/setup-go](https://github.com/actions/setup-go) | action | patch | `v5.0.0` -> `v5.0.1` | | [actions/upload-artifact](https://github.com/actions/upload-artifact) | action | patch | `v4.3.1` -> `v4.3.3` | | [actionsdesk/lfs-warning](https://github.com/actionsdesk/lfs-warning) | action | minor | `v3.2` -> `v3.3` | | [github/codeql-action](https://github.com/github/codeql-action) | action | minor | `v3.24.9` -> `v3.25.11` | | [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) | action | pinDigest | -> `d6238b0` | | [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | action | patch | `v2.3.1` -> `v2.3.3` | | [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) | action | pinDigest | -> `c747fe7` | | [slsa-framework/slsa-verifier](https://github.com/slsa-framework/slsa-verifier) | action | minor | `v2.4.1` -> `v2.5.1` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4.1.7`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v417) [Compare Source](https://github.com/actions/checkout/compare/v4.1.6...v4.1.7) - Bump the minor-npm-dependencies group across 1 directory with 4 updates by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1739 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1697 - Check out other refs/\* by commit by [@​orhantoy](https://github.com/orhantoy) in [actions/checkout#1774 - Pin actions/checkout's own workflows to a known, good, stable version. by [@​jww3](https://github.com/jww3) in [actions/checkout#1776 ### [`v4.1.6`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v416) [Compare Source](https://github.com/actions/checkout/compare/v4.1.5...v4.1.6) - Check platform to set archive extension appropriately by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1732 ### [`v4.1.5`](https://github.com/actions/checkout/releases/tag/v4.1.5) [Compare Source](https://github.com/actions/checkout/compare/v4.1.4...v4.1.5) #### What's Changed - Update NPM dependencies by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1703 - Bump github/codeql-action from 2 to 3 by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1694 - Bump actions/setup-node from 1 to 4 by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1696 - Bump actions/upload-artifact from 2 to 4 by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1695 - README: Suggest `user.email` to be `41898282+github-actions[bot]@​users.noreply.github.com` by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1707 **Full Changelog**: actions/checkout@v4.1.4...v4.1.5 ### [`v4.1.4`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v414) [Compare Source](https://github.com/actions/checkout/compare/v4.1.3...v4.1.4) - Disable `extensions.worktreeConfig` when disabling `sparse-checkout` by [@​jww3](https://github.com/jww3) in [actions/checkout#1692 - Add dependabot config by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1688 - Bump the minor-actions-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1693 - Bump word-wrap from 1.2.3 to 1.2.5 by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1643 ### [`v4.1.3`](https://github.com/actions/checkout/releases/tag/v4.1.3) [Compare Source](https://github.com/actions/checkout/compare/v4.1.2...v4.1.3) #### What's Changed - Update `actions/checkout` version in `update-main-version.yml` by [@​jww3](https://github.com/jww3) in [actions/checkout#1650 - Check git version before attempting to disable `sparse-checkout` by [@​jww3](https://github.com/jww3) in [actions/checkout#1656 - Add SSH user parameter by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1685 **Full Changelog**: actions/checkout@v4.1.2...v4.1.3 ### [`v4.1.2`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v412) [Compare Source](https://github.com/actions/checkout/compare/v4.1.1...v4.1.2) - Fix: Disable sparse checkout whenever `sparse-checkout` option is not present [@​dscho](https://github.com/dscho) in [actions/checkout#1598 </details> <details> <summary>actions/dependency-review-action (actions/dependency-review-action)</summary> ### [`v4.3.3`](https://github.com/actions/dependency-review-action/releases/tag/v4.3.3): Notes for v4.3.3 [Compare Source](https://github.com/actions/dependency-review-action/compare/v4.3.2...v4.3.3) #### What's Changed - Allow slashes in purl package names by [@​juxtin](https://github.com/juxtin) in [actions/dependency-review-action#765 - use the v3 version of the deps.dev API by [@​josieang](https://github.com/josieang) in [actions/dependency-review-action#741 - PR with suggestions - \[Improvement]: Help streamline / simplify dependency review action README by [@​am-stead](https://github.com/am-stead) in [actions/dependency-review-action#773 - fix show-openssf-scorecard-levels input by [@​ramann](https://github.com/ramann) in [actions/dependency-review-action#776 - Updates to the contribution guidelines by [@​jonjanego](https://github.com/jonjanego) in [actions/dependency-review-action#778 - Create issue templates by [@​jonjanego](https://github.com/jonjanego) in [actions/dependency-review-action#777 - Fix the max comment length issue by [@​jhutchings1](https://github.com/jhutchings1) and [@​elireisman](https://github.com/elireisman) in [actions/dependency-review-action#767 - Bump project version to 4.3.3 in prep for a release by [@​elireisman](https://github.com/elireisman) in [actions/dependency-review-action#781 #### New Contributors - [@​josieang](https://github.com/josieang) made their first contribution in [actions/dependency-review-action#741 - [@​am-stead](https://github.com/am-stead) made their first contribution in [actions/dependency-review-action#773 - [@​ramann](https://github.com/ramann) made their first contribution in [actions/dependency-review-action#776 **Full Changelog**: actions/dependency-review-action@v4.3.2...v4.3.3 ### [`v4.3.2`](https://github.com/actions/dependency-review-action/releases/tag/v4.3.2) [Compare Source](https://github.com/actions/dependency-review-action/compare/v4.3.1...v4.3.2) #### What's Changed - Fix package-url parsing for allow-dependencies-licenses by [@​juxtin](https://github.com/juxtin) in [actions/dependency-review-action#761 **Full Changelog**: actions/dependency-review-action@v4.3.1...v4.3.2 ### [`v4.3.1`](https://github.com/actions/dependency-review-action/releases/tag/v4.3.1) [Compare Source](https://github.com/actions/dependency-review-action/compare/v4.3.0...v4.3.1) #### What's Changed This release fixes some bugs related to package-url parsing that were introduced in 4.3.0. See [actions/dependency-review-action#753. **Full Changelog**: actions/dependency-review-action@V4.3.0...v4.3.1 ### [`v4.3.0`](https://github.com/actions/dependency-review-action/releases/tag/v4.3.0) [Compare Source](https://github.com/actions/dependency-review-action/compare/v4.2.5...v4.3.0) #### New Features - The `deny-packages` option can now be used without a version number to exclude *all* versions of a package. #### What's Changed - Fix action variable name for scorecard by [@​lukehinds](https://github.com/lukehinds) in [actions/dependency-review-action#735 - Fix extra https:// in summary by [@​jhutchings1](https://github.com/jhutchings1) in [actions/dependency-review-action#748 - Bump typescript from 5.3.3 to 5.4.5 by [@​dependabot](https://github.com/dependabot) in [actions/dependency-review-action#744 - Bump eslint-plugin-github from 4.10.1 to 4.10.2 by [@​dependabot](https://github.com/dependabot) in [actions/dependency-review-action#737 - Show denied packages with red X by [@​juxtin](https://github.com/juxtin) in [actions/dependency-review-action#750 - deny-packages configuration option can deny specified version or all packages by [@​febuiles](https://github.com/febuiles) and [@​bteng22](https://github.com/bteng22) in [actions/dependency-review-action#733 #### New Contributors - [@​bteng22](https://github.com/bteng22) made their first contribution in [actions/dependency-review-action#733 - [@​lukehinds](https://github.com/lukehinds) made their first contribution in [actions/dependency-review-action#735 **Full Changelog**: actions/dependency-review-action@v4.2.5...V4.3.0 </details> <details> <summary>actions/download-artifact (actions/download-artifact)</summary> ### [`v4.1.7`](https://github.com/actions/download-artifact/releases/tag/v4.1.7) [Compare Source](https://github.com/actions/download-artifact/compare/v4.1.6...v4.1.7) #### What's Changed - Update [@​actions/artifact](https://github.com/actions/artifact) dependency by [@​bethanyj28](https://github.com/bethanyj28) in [actions/download-artifact#325 **Full Changelog**: actions/download-artifact@v4.1.6...v4.1.7 ### [`v4.1.6`](https://github.com/actions/download-artifact/releases/tag/v4.1.6) [Compare Source](https://github.com/actions/download-artifact/compare/v4.1.5...v4.1.6) #### What's Changed - updating `@actions/artifact` dependency to v2.1.6 by [@​eggyhead](https://github.com/eggyhead) in [actions/download-artifact#324 **Full Changelog**: actions/download-artifact@v4.1.5...v4.1.6 ### [`v4.1.5`](https://github.com/actions/download-artifact/releases/tag/v4.1.5) [Compare Source](https://github.com/actions/download-artifact/compare/v4.1.4...v4.1.5) #### What's Changed - Update readme with v3/v2/v1 deprecation notice by [@​robherley](https://github.com/robherley) in [actions/download-artifact#322 - Update dependencies `@actions/core` to v1.10.1 and `@actions/artifact` to v2.1.5 **Full Changelog**: actions/download-artifact@v4.1.4...v4.1.5 </details> <details> <summary>actions/setup-go (actions/setup-go)</summary> ### [`v5.0.1`](https://github.com/actions/setup-go/releases/tag/v5.0.1) [Compare Source](https://github.com/actions/setup-go/compare/v5.0.0...v5.0.1) #### What's Changed - Bump undici from 5.28.2 to 5.28.3 and dependencies upgrade by [@​dependabot](https://github.com/dependabot) , [@​HarithaVattikuti](https://github.com/HarithaVattikuti) in [actions/setup-go#465 - Update documentation with latest V5 release notes by [@​ab](https://github.com/ab) in [actions/setup-go#459 - Update version documentation by [@​178inaba](https://github.com/178inaba) in [actions/setup-go#458 - Documentation update of `actions/setup-go` to v5 by [@​chenrui333](https://github.com/chenrui333) in [actions/setup-go#449 #### New Contributors - [@​ab](https://github.com/ab) made their first contribution in [actions/setup-go#459 **Full Changelog**: actions/setup-go@v5.0.0...v5.0.1 </details> <details> <summary>actions/upload-artifact (actions/upload-artifact)</summary> ### [`v4.3.3`](https://github.com/actions/upload-artifact/releases/tag/v4.3.3) [Compare Source](https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3) ##### What's Changed - updating `@actions/artifact` dependency to v2.1.6 by [@​eggyhead](https://github.com/eggyhead) in [actions/upload-artifact#565 **Full Changelog**: actions/upload-artifact@v4.3.2...v4.3.3 ### [`v4.3.2`](https://github.com/actions/upload-artifact/releases/tag/v4.3.2) [Compare Source](https://github.com/actions/upload-artifact/compare/v4.3.1...v4.3.2) #### What's Changed - Update release-new-action-version.yml by [@​konradpabjan](https://github.com/konradpabjan) in [actions/upload-artifact#516 - Minor fix to the migration readme by [@​andrewakim](https://github.com/andrewakim) in [actions/upload-artifact#523 - Update readme with v3/v2/v1 deprecation notice by [@​robherley](https://github.com/robherley) in [actions/upload-artifact#561 - updating `@actions/artifact` dependency to v2.1.5 and `@actions/core` to v1.0.1 by [@​eggyhead](https://github.com/eggyhead) in [actions/upload-artifact#562 #### New Contributors - [@​andrewakim](https://github.com/andrewakim) made their first contribution in [actions/upload-artifact#523 **Full Changelog**: actions/upload-artifact@v4.3.1...v4.3.2 </details> <details> <summary>actionsdesk/lfs-warning (actionsdesk/lfs-warning)</summary> ### [`v3.3`](https://github.com/ppremk/lfs-warning/releases/tag/v3.3) [Compare Source](https://github.com/actionsdesk/lfs-warning/compare/v3.2...v3.3) #### What's Changed - update node js to 16 by [@​GlazerMann](https://github.com/GlazerMann) in [ppremk/lfs-warning#148 - Fixing README to match repo move by [@​samthebest](https://github.com/samthebest) in [ppremk/lfs-warning#153 - Update CODEOWNERS by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#158 - Bump http-cache-semantics from 4.1.0 to 4.1.1 by [@​dependabot](https://github.com/dependabot) in [ppremk/lfs-warning#151 - Bump [@​babel/traverse](https://github.com/babel/traverse) from 7.15.4 to 7.23.4 by [@​dependabot](https://github.com/dependabot) in [ppremk/lfs-warning#159 - Bump tough-cookie from 4.0.0 to 4.1.3 by [@​dependabot](https://github.com/dependabot) in [ppremk/lfs-warning#160 - Bump cacheable-request and gts by [@​dependabot](https://github.com/dependabot) in [ppremk/lfs-warning#152 - Update emoji and convert file list to markdown list by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#161 - Bump got and gts by [@​dependabot](https://github.com/dependabot) in [ppremk/lfs-warning#155 - Exclude files without blob_url when getting PR blobs by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#162 - Support pull_request_target by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#164 - Update-node by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#163 - Fix text setup for the issue comment by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#166 - Validate PR changes to make sure there are no changes missing by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#165 - Fix emoji by [@​rajbos](https://github.com/rajbos) in [ppremk/lfs-warning#167 - Bump undici from 5.28.2 to 5.28.4 by [@​dependabot](https://github.com/dependabot) in [ppremk/lfs-warning#171 #### New Contributors - [@​GlazerMann](https://github.com/GlazerMann) made their first contribution in [ppremk/lfs-warning#148 - [@​samthebest](https://github.com/samthebest) made their first contribution in [ppremk/lfs-warning#153 - [@​rajbos](https://github.com/rajbos) made their first contribution in [ppremk/lfs-warning#158 **Full Changelog**: ppremk/lfs-warning@v3.2...v3.3 </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.25.11`](https://github.com/github/codeql-action/compare/v3.25.10...v3.25.11) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.10...v3.25.11) ### [`v3.25.10`](https://github.com/github/codeql-action/compare/v3.25.9...v3.25.10) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.9...v3.25.10) ### [`v3.25.9`](https://github.com/github/codeql-action/compare/v3.25.8...v3.25.9) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.8...v3.25.9) ### [`v3.25.8`](https://github.com/github/codeql-action/compare/v3.25.7...v3.25.8) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.7...v3.25.8) ### [`v3.25.7`](https://github.com/github/codeql-action/compare/v3.25.6...v3.25.7) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.6...v3.25.7) ### [`v3.25.6`](https://github.com/github/codeql-action/compare/v3.25.5...v3.25.6) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.5...v3.25.6) ### [`v3.25.5`](https://github.com/github/codeql-action/compare/v3.25.4...v3.25.5) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.4...v3.25.5) ### [`v3.25.4`](https://github.com/github/codeql-action/compare/v3.25.3...v3.25.4) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.3...v3.25.4) ### [`v3.25.3`](https://github.com/github/codeql-action/compare/v3.25.2...v3.25.3) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.2...v3.25.3) ### [`v3.25.2`](https://github.com/github/codeql-action/compare/v3.25.1...v3.25.2) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.1...v3.25.2) ### [`v3.25.1`](https://github.com/github/codeql-action/compare/v3.25.0...v3.25.1) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.0...v3.25.1) ### [`v3.25.0`](https://github.com/github/codeql-action/compare/v3.24.10...v3.25.0) [Compare Source](https://github.com/github/codeql-action/compare/v3.24.11...v3.25.0) ### [`v3.24.11`](https://github.com/github/codeql-action/compare/v3.24.10...v3.24.11) [Compare Source](https://github.com/github/codeql-action/compare/v3.24.10...v3.24.11) ### [`v3.24.10`](https://github.com/github/codeql-action/compare/v3.24.9...v3.24.10) [Compare Source](https://github.com/github/codeql-action/compare/v3.24.9...v3.24.10) </details> <details> <summary>ossf/scorecard-action (ossf/scorecard-action)</summary> ### [`v2.3.3`](https://github.com/ossf/scorecard-action/releases/tag/v2.3.3) [Compare Source](https://github.com/ossf/scorecard-action/compare/v2.3.2...v2.3.3) > \[!NOTE]\ > There is no v2.3.2 release as a step was skipped in the release process. This was fixed and re-released under the v2.3.3 tag #### What's Changed - 🌱 Bump github.com/ossf/scorecard/v4 (v4.13.1) to github.com/ossf/scorecard/v5 (v5.0.0-rc1) by [@​spencerschrock](https://github.com/spencerschrock) in [ossf/scorecard-action#1366 - 🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc1 to v5.0.0-rc2 by [@​spencerschrock](https://github.com/spencerschrock) in [ossf/scorecard-action#1374 - 🌱 Bump github.com/ossf/scorecard/v5 from v5.0.0-rc2 to v5.0.0-rc2.0.20240509182734-7ce860946928 by [@​spencerschrock](https://github.com/spencerschrock) in [ossf/scorecard-action#1377 For a full changelist of what these include, see the [v5.0.0-rc1](https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc1) and [v5.0.0-rc2](https://github.com/ossf/scorecard/releases/tag/v5.0.0-rc2) release notes. ##### Documentation - 📖 Move token discussion out of main README. by [@​spencerschrock](https://github.com/spencerschrock) in [ossf/scorecard-action#1279 - 📖 link to `ossf/scorecard` workflow instead of maintaining an example by [@​spencerschrock](https://github.com/spencerschrock) in [ossf/scorecard-action#1352 - 📖 update api links to new scorecard.dev site by [@​spencerschrock](https://github.com/spencerschrock) in [ossf/scorecard-action#1376 **Full Changelog**: ossf/scorecard-action@v2.3.1...v2.3.3 ### [`v2.3.2`](https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.2) [Compare Source](https://github.com/ossf/scorecard-action/compare/v2.3.1...v2.3.2) </details> <details> <summary>slsa-framework/slsa-verifier (slsa-framework/slsa-verifier)</summary> ### [`v2.5.1`](https://github.com/slsa-framework/slsa-verifier/releases/tag/v2.5.1) [Compare Source](https://github.com/slsa-framework/slsa-verifier/compare/v2.4.1...v2.5.1) #### What's Changed - feat: Add cosign registry opts for provenance registry by [@​saisatishkarra](https://github.com/saisatishkarra) in [#729 and [#736 - feat: Add support for DSSE Rekor type by [@​haydentherapper](https://github.com/haydentherapper) in [#742 #### New Contributors - [@​saisatishkarra](https://github.com/saisatishkarra) made their first contribution in [#729 - [@​ramonpetgrave64](https://github.com/ramonpetgrave64) made their first contribution in [#737 - [@​haydentherapper](https://github.com/haydentherapper) made their first contribution in [#742 **Full Changelog**: v2.4.1...v2.5.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/slsa-framework/slsa-verifier). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Ramon Petgrave <32398091+ramonpetgrave64@users.noreply.github.com>
Closes #752
Bottom line: the problems in the linked issue appear to be caused by the fact that we've been playing fast and loose with package-urls in a few different ways:
deny-groups
, we try to accept package-urls with a namespace but no name, but those kinds of package-urls are invalid according to the spec. In order to get around that, we sort of abuse thepackageurl-js
library.package_url
member from the comparison API. However, it appears that this isn't always populated. Specifically, when a dependency has a version range like^1.2.3
, there's no way to format it into a package-url, so we just don't. These missingpackage_url
s have been causing runtime exceptions.pkg:npm/@ns/pkg@1.0.0
even though it's technically invalid. This is helpful for our users, many of whom probably don't know the minutiae of the package-url spec. Thepackageurl-js
library does not make this affordance.What I've done in this PR is write a very simple, permissive parser for package-urls that fits our purposes more closely than
packageurl-js
does. It allows us to parse partial purls, reports errors without throwing them, and tolerates special characters as long as the whole purl can still be unambiguously parsed.In addition, I've made the following changes/improvements:
deny-groups
that requires a namespace to be present. We used to tell users to use a purl fragment likepkg:npm/express
to block theexpress
namespace, butpkg:npm/express
is a complete and valid purl that specifies theexpress
package. Instead, the format should bepkg:npm/express/
, where the trailing/
indicates thatexpress
is a namespace and not a package name.deny-groups
requires a namespace.package_url
for a dependency, get the namespace from the package name.In my test repositories reproducing the error reports we've gotten from users, these changes have successfully fixed the problems.